Not sure why it has not run any CI. Am I right that currently this test fails?

Not sure why it has not run any CI. Am I right that currently this test fails?

Yes, you are correct. The changes that you have implemented are incomplete. I have been trying to warn you guys about it for a while. For one thing, the CommitEncode trait is currently implemented for Assignments using the UsingStrict strategy, which does not conceal the assignments.

If you look at my original PR (#6) you will see that the CommitEncode trait needs to be explicitly implemented for Assignments and OwnedState<STATE> (in addition to Void that has already been implemented). I have added several comments to #6 explaining the reasons for that.

The part on the RGB Core is WIP, so yes, it is incomplete. And I see no other way of meeting all spec requirements from https://github.com/LNP-BP/LNPBPs/discussions/88 other than this. The marker trait you proposed does not solve linearization problem for nested tree maps, and also we need to introduce proper merkle tree node tagging.

Closed & reopened in attempt to make CI work and see that it fails on this test

Ouch, I see, the PR is against non-master, that's why CI is not running. Can you pls do another PR against master so we can see that the master does not pass this test (meaning that the test is correct)?

The part on the RGB Core is WIP, so yes, it is incomplete. And I see no other way of meeting all spec requirements from LNP-BP/LNPBPs#88 other than this. The marker trait you proposed does not solve linearization problem for nested tree maps, and also we need to introduce proper merkle tree node tagging.

@dr-orlovsky, I was not referring to the proposed change to the client_side_validation crate. Please forget about it for now, and pay attention to how the CommitEncode trait is currently implemented for the Assignments type.

https://github.com/rgb-org/rgb-core/blob/bf1bac19a27ec9a974d5d2412085d9081f9f3fcb/src/contract/assignments.rs#L406-L408

It should be using the UsingConceal strategy, not the UsingStrict strategy as it is now.

@claudiosdc Thanks for pointing that out, Assignments were set to UsingConceal few commits ago.

Anyway, #8 is finalized now, you are welcome to review (however it is rather large and complex, addressing many other issues than just node_id mutability).